Ticket #707 (defect)

Opened 4 months ago

Last modified 4 months ago

Projects cannot be marked as Completed

Status: closed (fixed)

Reported by: hans@degraaff.org Assigned to: lukemelia
Priority: normal Milestone: 1.6
Component: Coding Version: trunk
Severity: critical Keywords:
Cc: hans@degraaff.org, ericpallen@gmail.com

Currently (with r838) projects can't be marked as Completed (or any Hidden or Active for that matter). Clicking on each of the radiobuttons does cause a request to be sent to the application, but that request does not contain the new state information, and thus nothing gets changed:

Processing ProjectsController#update? (for 2001:888:10:11d::3 at 2008-05-04 08:33:46) [PUT]

Parameters: {"_method"=>"put", "authenticity_token"=>"some_chars", "action"=>"update", "id"=>"10", "controller"=>"projects"}

Change History

05/07/08 16:24:56: Modified by ericpallen@gmail.com

  • cc changed from hans@degraaff.org to hans@degraaff.org, ericpallen@gmail.com.

I can confirm that rev 837, "Merged rails2-branch back into trunk. Trunk Tracks is now using Rails 2.0.2," is where the problem started.

05/12/08 18:41:32: Modified by lrbalt

  • version set to trunk.
  • milestone set to 1.6.

05/12/08 19:30:19: Modified by lrbalt

  • owner changed from bsag to lukemelia.

I'm trying to figure this out. Seems like the remote_function in show.html.erb on line 48 does not use the :with parameter. Is this something that was changed in rails2?

Luke, any idea?

05/12/08 19:36:28: Modified by lrbalt

this has something to do with the forgery_protection. If I add

config.action_controller.allow_forgery_protection = false

to my development.rb in /config/environments, you can mark projects complete / active again

05/12/08 20:14:05: Modified by lrbalt

  • status changed from new to closed.
  • resolution set to fixed.

I think I fixed this in [846]. Inspired by Luke's previous fix.

Interesting that the tests did not catch this

05/13/08 04:50:54: Modified by hans@degraaff.org

This works fine for me. However, the tracks_837.js file that got checked in in r845 seems to be empty, so I had to regenerate it manually.

05/13/08 07:55:50: Modified by lrbalt

thanks Hans. I've committed a newly generated (not-empty) .js